Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open external links in web browser #506

Merged
merged 3 commits into from
Jun 22, 2020
Merged

Open external links in web browser #506

merged 3 commits into from
Jun 22, 2020

Conversation

nevalla
Copy link
Contributor

@nevalla nevalla commented Jun 22, 2020

This PR will open external links (links that have target="_blank") in a web browser.

Fixes #502

Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
@nevalla nevalla added the bug Something isn't working label Jun 22, 2020
@nevalla nevalla added this to the 3.5.1 milestone Jun 22, 2020
@nevalla nevalla requested a review from a team June 22, 2020 13:42
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
@nevalla nevalla merged commit b8c1d78 into master Jun 22, 2020
@nevalla nevalla deleted the open-external-links branch June 22, 2020 20:27
nevalla added a commit that referenced this pull request Jun 24, 2020
This was referenced Jun 24, 2020
@jakolehm jakolehm mentioned this pull request Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in chart descriptions don't work
3 participants