Fix Pod Container sorting not correlating to visuals #5175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
requested review from
DmitriyNoa and
JAtula
and removed request for
a team
aleksfront
requested changes
Apr 4, 2022
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- Add some specific tuple.zip types - Remove the `string` part of `TableOrderBy` to simplify implementation and because it removes any sort of intellisense Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
aleksfront
approved these changes
Jun 3, 2022
ixrock
approved these changes
Aug 2, 2022
jansav
pushed a commit
that referenced
this pull request
Aug 9, 2022
(cherry picked from commit 2b24a42)
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some specific tuple.zip types
Remove the
stringpart ofTableOrderByto simplify implementationand because it removes any sort of intellisense
Signed-off-by: Sebastian Malton sebastian@malton.name
fixes #5165