Stop overriding intree extension versions on build #6239
Conversation
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
requested review from
ixrock and
jim-docker
and removed request for
a team
| .PHONY: update-extension-locks | ||
| update-extension-locks: | ||
| $(foreach dir, $(extensions), (cd $(dir) && rm package-lock.json && ../../node_modules/.bin/npm install --package-lock-only);) |
There was a problem hiding this comment.
This is unused as we no longer keep those package-lock files in git
| @@ -92,7 +87,7 @@ src/extensions/npm/extensions/dist: src/extensions/npm/extensions/node_modules | |||
| yarn compile:extension-types | |||
|
|
|||
| src/extensions/npm/extensions/node_modules: src/extensions/npm/extensions/package.json | |||
| cd src/extensions/npm/extensions/ && ../../../../node_modules/.bin/npm install --no-audit --no-fund | |||
There was a problem hiding this comment.
We aren't really using the package-lock file anyway since we override it whenever we do a make build-extension-types invocation.
There was a problem hiding this comment.
Just wondering should we include package-locks... anyway that is a story for an another PR.
There was a problem hiding this comment.
Yeah probably. Once these are libraries and build themselves for the releases.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "kube-object-event-status", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
This version needs to be higher than any version currently in the wild but we also don't need to set it on every build. Only when we change the extension.
| "@material-ui/core": "^4.12.3", | ||
| "@types/node": "^16.11.58", |
There was a problem hiding this comment.
These are changed to make them the same as what we have in the root package.json
|
Marking this as |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "lens-metrics-cluster-feature", | |||
| "version": "0.0.1", | |||
| "version": "6.1.0", | |||
There was a problem hiding this comment.
Can you tell more about reason to set extension version numbers same as Lens version itself? Also, by your design, should we change those versions on every app release? For example, next release would be 6.2.0 and extensions will stay with 6.1.0?
There was a problem hiding this comment.
The reason that was to make sure that any new updates to the extensions ensure that they are always up to date (because newer versions will be overridden during update). But if there are no changes then I don't see the point of ensuring that.
If we make a change to the extensions then we should bump the versions.
|
@jakolehm PTAL |
| @@ -92,7 +87,7 @@ src/extensions/npm/extensions/dist: src/extensions/npm/extensions/node_modules | |||
| yarn compile:extension-types | |||
|
|
|||
| src/extensions/npm/extensions/node_modules: src/extensions/npm/extensions/package.json | |||
| cd src/extensions/npm/extensions/ && ../../../../node_modules/.bin/npm install --no-audit --no-fund | |||
There was a problem hiding this comment.
Just wondering should we include package-locks... anyway that is a story for an another PR.
Signed-off-by: Sebastian Malton sebastian@malton.name