Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on clean startup #6276

Merged
merged 7 commits into from
Sep 20, 2022
Merged

Fix crash on clean startup #6276

merged 7 commits into from
Sep 20, 2022

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Sep 19, 2022

Signed-off-by: Sebastian Malton sebastian@malton.name

Description of changes:

  • Make initialization of ReleaseChannel, DefaultUpdateChannel , and UserStore all explicit and correct in terms of timing.
  • This allows people to inject(userStoreInjectable) without having to know about initialization order

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
…iming errors

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 requested a review from a team as a code owner September 19, 2022 14:56
@Nokel81 Nokel81 requested review from ixrock and aleksfront and removed request for a team September 19, 2022 14:56
@Nokel81 Nokel81 added bug Something isn't working blocker labels Sep 19, 2022
@Nokel81 Nokel81 added this to the 6.1.0 milestone Sep 19, 2022
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Iku-turso
Iku-turso previously approved these changes Sep 19, 2022
Copy link
Contributor

@Iku-turso Iku-turso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test to reproduce the error is missing but ok :)

jim-docker
jim-docker previously approved these changes Sep 19, 2022
Copy link
Contributor

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't have time to test

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 dismissed stale reviews from jim-docker and Iku-turso via d262b15 September 19, 2022 15:18
Iku-turso
Iku-turso previously approved these changes Sep 19, 2022
jim-docker
jim-docker previously approved these changes Sep 19, 2022
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 dismissed stale reviews from jim-docker and Iku-turso via 8a90c23 September 19, 2022 20:35
jim-docker
jim-docker previously approved these changes Sep 19, 2022
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 merged commit 4c49134 into master Sep 20, 2022
@Nokel81 Nokel81 deleted the fix-init-timing branch September 20, 2022 06:19
@panuhorsmalahti panuhorsmalahti mentioned this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants