Clickable links in pods details for ServiceAccount, PriorityClass and RuntimeClass #6352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dex4er
requested review from
jansav and
aleksfront
and removed request for
a team
dex4er
force-pushed
the
clickable-links-in-pod-details
branch
from
0979d69
to
2ae24ab
Compare
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
dex4er
force-pushed
the
clickable-links-in-pod-details
branch
from
2ae24ab
to
253ef2d
Compare
Nokel81
requested changes
Oct 7, 2022
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
dex4er
force-pushed
the
clickable-links-in-pod-details
branch
from
e532144
to
93960e4
Compare
|
@dex4er Please resolve lint issues and then this LGTM |
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Nokel81
approved these changes
Oct 11, 2022
|
@dex4er Thanks again! |
|
@Nokel81 Linter clean. I forgot there is |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small improvement for pod details:
Links to ServiceAccount, PriorityClass and RuntimeClass are clickable and move to the details of the chosen resource.