New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a way to add cluster frame components in Extension API #6385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
aleksfront
added
enhancement
New feature or request
area/extension
Something to related to the extension api
labels
Oct 10, 2022
aleksfront
requested review from
jansav and
Nokel81
and removed request for
a team
October 10, 2022 11:38
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Nokel81
requested changes
Oct 11, 2022
jansav
reviewed
Oct 12, 2022
Iku-turso
reviewed
Oct 19, 2022
src/renderer/cluster-modals/cluster-modals-registrator.injectable.ts
Outdated
Show resolved
Hide resolved
Iku-turso
reviewed
Oct 19, 2022
Iku-turso
reviewed
Oct 19, 2022
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
for specific extension elements Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
aleksfront
changed the title
Cluster view modals registry
Cluster frame components registry
Nov 3, 2022
Nokel81
previously approved these changes
Nov 3, 2022
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
jansav
force-pushed
the
app-modal-registry
branch
from
November 4, 2022 05:33
12c6f89
to
0a96c77
Compare
jansav
changed the title
Cluster frame components registry
Expose a way to add cluster frame components in Extension API
Nov 4, 2022
Pushed 3 commits:
After these, the implementation didn't match the name of PR anymore, so I updated the PR. As you can see, the current implementation is a lot smaller and does exactly same thing. |
jansav
approved these changes
Nov 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New registry for registering html elements into the top of the cluster views. Should be used for modals and dialogs.Expose a way to add cluster frame components in Extensions. Usable for e.g. modals and dialogs.