Clickable StorageClass #6410
Merged
Clickable StorageClass #6410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dex4er
requested review from
Iku-turso and
ixrock
and removed request for
a team
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
dex4er
force-pushed
the
clickable-storageclass
branch
from
13fc3f4
to
afcc54e
Compare
aleksfront
approved these changes
Oct 14, 2022
| <DrawerItem name="Access Modes"> | ||
| {accessModes?.join(", ")} | ||
| </DrawerItem> | ||
| <DrawerItem name="Storage Class Name"> | ||
| {storageClassName} | ||
| <Link | ||
| key="link" |
There was a problem hiding this comment.
We do not need key prop here for a standalone <Link/> component.
| @@ -57,10 +62,16 @@ export class PersistentVolumeDetails extends React.Component<PersistentVolumeDet | |||
| {persistentVolumeReclaimPolicy} | |||
| </DrawerItem> | |||
| <DrawerItem name="Storage Class Name"> | |||
| {storageClassName} | |||
| <Link | |||
| key="link" | |||
There was a problem hiding this comment.
We do not need key prop here for a standalone <Link/> component.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This patch enabled clickable storageClassName in PV and PVC detailed view.