Remove hyperlink of Helm Maintainers #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead just show the name and email Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
requested review from
Iku-turso and
ixrock
and removed request for
a team
jim-docker
approved these changes
Nov 16, 2022
| ))} | ||
| {selectedChart.getMaintainers() | ||
| .map(({ name, email }) => ( | ||
| <li key={name}>{`${name}<${email}>`}</li> |
There was a problem hiding this comment.
Maybe a space here?
Suggested change
| <li key={name}>{`${name}<${email}>`}</li> | |
| <li key={name}>{`${name} <${email}>`}</li> |
There was a problem hiding this comment.
As stated in https://superuser.com/a/1625692 and in the corresponding RFC the space is optional so I think it is fine for the time being.
aleksfront
approved these changes
Nov 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name