Block renderering non http(s):// links via <Icon>
#6588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
requested review from
jansav and
aleksfront
and removed request for
a team
jim-docker
reviewed
Nov 16, 2022
There was a problem hiding this comment.
Getting a lot of these errors trying to build:
ERROR in /Users/jimehrismann/git/lensapp/lens/src/renderer/components/menu/menu-actions.tsx
./src/renderer/components/menu/menu-actions.tsx 163:16-23
[tsl] ERROR in /Users/jimehrismann/git/lensapp/lens/src/renderer/components/menu/menu-actions.tsx(163,17)
TS2322: Type '{ material: string; interactive: boolean | undefined; tooltip: string; }' is not assignable to type 'IntrinsicAttributes & IconProps & { children?: ReactNode; }'.
Property 'tooltip' does not exist on type 'IntrinsicAttributes & IconProps & { children?: ReactNode; }'.
|
Thanks well look into this |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
@jim-docker Fixed |
jim-docker
reviewed
Nov 16, 2022
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
@jim-docker Done |
aleksfront
previously approved these changes
Nov 17, 2022
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name