Make ResourceStack fully injectable #6591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
added
bug
Nokel81
requested review from
Iku-turso and
aleksfront
and removed request for
a team
Nokel81
added
chore
and removed
bug
Nokel81
changed the title
Nokel81
force-pushed
the
fix-metrics-apply-macOS
branch
from
f36aafc
to
d15dadf
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Nokel81
force-pushed
the
fix-metrics-apply-macOS
branch
from
d15dadf
to
5b66c8e
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
fix-metrics-apply-macOS
branch
from
5b66c8e
to
d4114dc
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
jim-docker
approved these changes
Nov 24, 2022
| @@ -0,0 +1,19 @@ | |||
| /** | |||
There was a problem hiding this comment.
Nit: name should be src/renderer/kubectl/kubectl-apply-all.injectable.ts since the main partner is src/main/kubectl/kubectl-apply-all.injectable.ts
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name