Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renderer file logging transport #6795

Merged
merged 8 commits into from
Feb 8, 2023
Merged

Renderer file logging transport #6795

merged 8 commits into from
Feb 8, 2023

Commits on Jan 30, 2023

  1. Renderer file logging transport 

    Add file logging to renderer, writing separate log files for renderer main frame and each cluster frame.

Related to lensapp/support-lens-extension#118

Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    03d51a7 View commit details
    Browse the repository at this point in the history

  2. Switch renderer file log level to info 

    There is too much noise on debug level from api responses etc

Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    e1da883 View commit details
    Browse the repository at this point in the history

  3. Unmount on pagehide instead of beforeunload 

    It seems cluster onbeforeunload is not triggered when iframe is removed from dom by the parent (when disconnecting a cluster).

While on root/main frame the beforeunload event does work, it seems to be adviced to use pagehide instead.

Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    528e18e View commit details
    Browse the repository at this point in the history

  4. Close log files on unmount 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    0c83cfb View commit details
    Browse the repository at this point in the history

  5. Improve file handle closing in different situations 

    This should cover reloading main and cluster frames and closing cluster frame throught disconnecting cluster. No file handles should be left open now.

Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    da946cf View commit details
    Browse the repository at this point in the history

  6. Fix renderer log rotation 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7a4e3a7 View commit details
    Browse the repository at this point in the history

  7. Switch back to beforeunload in root frame 

    Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    e35e470 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Remove capturing phase event usage 

    Does not seem to be needed for log files to be successfully closed and caused integration tests to fail.

Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
    @samitiilikainen
    samitiilikainen committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    fbb17b7 View commit details
    Browse the repository at this point in the history