Allow CatalogEntityDetails to be opened anywhere #6939
Conversation
Nokel81
requested review from
jansav and
jim-docker
and removed request for
a team
Nokel81
force-pushed
the
catalog-entity-details-anywhere
branch
from
bdbfaf2
to
4364c9c
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Nokel81
force-pushed
the
catalog-entity-details-anywhere
branch
from
4364c9c
to
46265dd
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Nokel81
force-pushed
the
catalog-entity-details-anywhere
branch
from
46265dd
to
6551d7a
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
| @@ -0,0 +1,19 @@ | |||
| /** | |||
There was a problem hiding this comment.
injectable creep? So many injectables
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
catalog-entity-details-anywhere
branch
from
ec0fea5
to
9103d4d
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
| @@ -129,6 +133,7 @@ describe("opening catalog entity details panel", () => { | |||
| describe("when opening the menu 'some-kubernetes-cluster'", () => { | |||
| beforeEach(() => { | |||
| rendered.getByTestId("icon-for-menu-actions-for-catalog-for-some-entity-id").click(); | |||
| advanceFakeTime(1000); | |||
There was a problem hiding this comment.
Is the 1000ms something special here? The name of describe doesn't really provide any information and I would have to dig deeper in the code. What happens after 999ms?
There was a problem hiding this comment.
This is to cover animations
There was a problem hiding this comment.
Advancing of the fake time is not clear in the behavioural tests. I would like to see what happens after e.g. 999ms and 1000ms so that I can immediately see what's the time were waiting for. Also it would start bringing up more corner cases, e.g. what happens if I click something twice which does something only after 1000ms.
Signed-off-by: Sebastian Malton sebastian@malton.name
Also expose this functionality to the extension API.
resolves #4963