Improvements and more stability in support HMR/live-reload #6948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v-server` config Signed-off-by: Roman <ixrock@gmail.com>
ixrock
requested review from
jansav and
aleksfront
and removed request for
a team
jakolehm
approved these changes
Jan 16, 2023
Merged
ixrock
added a commit
that referenced
this pull request
Feb 3, 2023
…tion while reloading, part of #6948 Signed-off-by: Roman <ixrock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For currently used
webpack-dev-server@4.x:Before: in some cases HMR/page-reload didn't happen, e.g. editing
welcome.tsxwith follow up manual page reload:Screen.Recording.2023-01-16.at.16.36.05.mov
After: (no need to do
Cmd+Rwhen HMR cannot be applied in some cases, see screenshot with error below)On first editing
welcome.tsxa whole app might be restarted, but just once. Next edits ofwelcome.tsxbehaves like autoCmd+R.Screen.Recording.2023-01-16.at.16.29.42.mov
Caught error from video why page-reload happens instead of HMR: