Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BaseStore<T> and replace with composition of dependencies #7002

Merged
merged 34 commits into from
Mar 28, 2023
Merged

Remove BaseStore<T> and replace with composition of dependencies #7002

merged 34 commits into from
Mar 28, 2023

Commits on Mar 22, 2023

  1. Rename ExtensionStore -> BaseExtensionStore 

    - The name was too close to ExtensionsStore

Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    42fd783 View commit details
    Browse the repository at this point in the history

  2. Move ExtensionsStore to new format 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    bd594e1 View commit details
    Browse the repository at this point in the history

  3. Move ClusterStore to new format 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d2485d4 View commit details
    Browse the repository at this point in the history

  4. Move UserStore to new format 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    337189b View commit details
    Browse the repository at this point in the history

  5. Cleanup types to remove multiple cast locations 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    4caf77a View commit details
    Browse the repository at this point in the history

  6. Move HotbarStore to new format 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    acefc03 View commit details
    Browse the repository at this point in the history

  7. Move WeblinkStore to new format 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f1f72b1 View commit details
    Browse the repository at this point in the history

  8. Move FileSystemProvisionerStore to new format 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    7fec6b0 View commit details
    Browse the repository at this point in the history

  9. Update snapshots 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    4074d59 View commit details
    Browse the repository at this point in the history

  10. Clean up impl and rename to better describe intent 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    dbb9a0f View commit details
    Browse the repository at this point in the history

  11. Fix remaining type errors 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    31a3369 View commit details
    Browse the repository at this point in the history

  12. Fully split apart the enabled extensions storage 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    12e4388 View commit details
    Browse the repository at this point in the history

  13. Fully split apart the clusters storage 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f1f8e19 View commit details
    Browse the repository at this point in the history

  14. Fully split apart the hotbar storage 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ae32375 View commit details
    Browse the repository at this point in the history

  15. Fully split apart the weblinks storage 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    037c62d View commit details
    Browse the repository at this point in the history

  16. Fully split apart the user preferences storage 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    4055732 View commit details
    Browse the repository at this point in the history

  17. Fix crashing 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    a446a25 View commit details
    Browse the repository at this point in the history

  18. Fix tests and snapshots 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    34dafcd View commit details
    Browse the repository at this point in the history

  19. Fix integration test failures 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    83b72f1 View commit details
    Browse the repository at this point in the history

  20. Improve typing to prevent errors in the future. 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ea7a24d View commit details
    Browse the repository at this point in the history

  21. Cleanup @k8slens/messaging and friends 

    - To fix type errors

Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    a445fdd View commit details
    Browse the repository at this point in the history

  22. Fix lint issue 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    cb538bf View commit details
    Browse the repository at this point in the history

  23. Fix type errors 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    b5178c7 View commit details
    Browse the repository at this point in the history

  24. Fix global override not being complete enough causing tests to fail 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ff1c176 View commit details
    Browse the repository at this point in the history

  25. Bump memory for unit tests on CI 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    6fba195 View commit details
    Browse the repository at this point in the history

  26. Attempt to fix memory issue on CI again 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    eb5f660 View commit details
    Browse the repository at this point in the history

  27. Fixup test because of new injectables 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    6e65fda View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Upgrade Jest 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    af46ca7 View commit details
    Browse the repository at this point in the history

  2. Fix unit tests falling over 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    0989278 View commit details
    Browse the repository at this point in the history

  3. Back out jest config change 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    2845df8 View commit details
    Browse the repository at this point in the history

  4. Remove console log 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    93c309d View commit details
    Browse the repository at this point in the history

  5. Update snapshot 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    b18efcc View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Fix tests by matching equality instead of snapshots 

    Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    81b2179 View commit details
    Browse the repository at this point in the history

  2. Fix tests by forcing specific snapshot style 

    - Ubuntu CI seems to format arrays in snapshots differently than macOS locally

Signed-off-by: Sebastian Malton <sebastian@malton.name>
    @Nokel81
    Nokel81 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    7f9fc5c View commit details
    Browse the repository at this point in the history