Fix extension installation #7161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
jansav
requested review from
Iku-turso,
ixrock,
Nokel81 and
jim-docker
and removed request for
a team,
ixrock,
jim-docker and
Iku-turso
jansav
changed the title
ixrock
approved these changes
Feb 15, 2023
aleksfront
approved these changes
Feb 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's code that removes the
package.jsonfile from extension even though it's not supposed to do so. This code was added in #1718.Fixes #7141
By looking at the code, I can see many major problems with it, but here's the minimal fix. Decided that I'm not going to do any major rework for the extension discovery / -loading since it will be rebuilt to support new type of extensions (Features) soon.
Examples:
rendereraccesses file system directlyrendererdownloads the extension