Fix log tab double scrollbars bug #7178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
aleksfront
requested review from
Iku-turso and
ixrock
and removed request for
a team
Nokel81
reviewed
Feb 16, 2023
Comment on lines
-10
to
-13
| // fix for `this.logsElement.scrollTop = this.logsElement.scrollHeight` | ||
| // `overflow: overlay` don't allow scroll to the last line | ||
| overflow: auto; | ||
|
|
There was a problem hiding this comment.
Is this no longer a problem then?
There was a problem hiding this comment.
I don't see any problems for now. It sticks to the bottom line and has proper behavior scrolling to the very top.
pod.logs.proper.behavior.mov
ixrock
approved these changes
Feb 17, 2023
Nokel81
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Replace logsViewModelInjectable lifecycle to keyedSingleton Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Await logs view model to instantiate Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Remove async from instantiating LogTabViewModel Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Fix LogList overflow (#7178) Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> --------- Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
double.scrolls.bug.mov
After:
fixed.double.scrolls.bug.mov