Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: removed duplicated labels & annotations for Node-details view #7202

Merged
merged 1 commit into from Feb 21, 2023

Conversation

ixrock
Copy link
Member

@ixrock ixrock commented Feb 21, 2023

By default this info is shown in every resource-details view (default-kube-meta-details-item.injectable.ts injects <KubeObjectMeta/> at the top of details-view contents)

Screenshot 2023-02-21 at 13 48 44

By default this info is shown in every resource-details view (`default-kube-meta-details-item.injectable.ts` injects `<KubeObjectMeta/>` at the top of details-view contents)

Signed-off-by: Roman <ixrock@gmail.com>
@ixrock ixrock added the bug Something isn't working label Feb 21, 2023
@ixrock ixrock added this to the 6.4.0 milestone Feb 21, 2023
@ixrock ixrock requested a review from a team as a code owner February 21, 2023 11:55
@ixrock ixrock self-assigned this Feb 21, 2023
@ixrock ixrock requested review from jansav and Nokel81 and removed request for a team February 21, 2023 11:55
@Nokel81 Nokel81 merged commit b3ae5a0 into master Feb 21, 2023
@Nokel81 Nokel81 deleted the fix/node_details_duplicated_labels branch February 21, 2023 12:49
jansav pushed a commit that referenced this pull request Feb 22, 2023
…7202)

By default this info is shown in every resource-details view (`default-kube-meta-details-item.injectable.ts` injects `<KubeObjectMeta/>` at the top of details-view contents)

Signed-off-by: Roman <ixrock@gmail.com>
(cherry picked from commit b3ae5a0)
Nokel81 pushed a commit that referenced this pull request Feb 22, 2023
…7202)

By default this info is shown in every resource-details view (`default-kube-meta-details-item.injectable.ts` injects `<KubeObjectMeta/>` at the top of details-view contents)

Signed-off-by: Roman <ixrock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants