Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish work to make bootstrap only use startFrame #7205

Closed
wants to merge 40 commits into from
Closed

Finish work to make bootstrap only use startFrame #7205

wants to merge 40 commits into from

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Feb 21, 2023

Signed-off-by: Sebastian Malton sebastian@malton.name

This PR also replaces the work done in #7189.

@Nokel81 Nokel81 added the chore label Feb 21, 2023
@Nokel81 Nokel81 added this to the 6.5.0 milestone Feb 21, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nokel81 Nokel81 marked this pull request as ready for review February 21, 2023 19:33
@Nokel81 Nokel81 requested a review from a team as a code owner February 21, 2023 19:33
@Nokel81 Nokel81 requested review from jansav and Iku-turso and removed request for a team February 21, 2023 19:33
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Nokel81 Nokel81 force-pushed the change-extension-loader-create-extensions branch from 6bfb929 to 00958ca Compare February 23, 2023 20:53
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nokel81 Nokel81 force-pushed the change-extension-loader-create-extensions branch from 00958ca to be2350a Compare February 23, 2023 21:05
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Nokel81 Nokel81 force-pushed the change-extension-loader-create-extensions branch from 78aebbb to ca9ba58 Compare March 1, 2023 15:47
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nokel81
Cleanup more type errors
e946194 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix type errors
504d086 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Move cluster failed to list namespaces to injectable
38de2ed 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Move too many hotbar items notification to injectable
1dd172e 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Move last main frame into into runnable
4561a59 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix type error
28c1455 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix lint
16d7baa 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove finished TODO
4fe38cc 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix raw requests not being handled in tests
9704598 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Add support for canceling a delay
5591c59 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Revert dynamic adding #app DIV
0a9e858 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove delay in waiting for bundled extensions during testing
b239ced 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove finished TODO
ae6caea 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove logging frameId as unnecessary
98740c9 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Cleanup renderFor impl to be simpler
2bff8cc 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix not emitting bundled extensions are loaded in cluster frame
d2d4ffb 
- Fixes tests that relied on root frame being initialized before cluster frames

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Remove console logs and fix stubs to fix tests
45b22ff 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix injectable not being in both environments
8267432 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix injectable not being in both environments
f3869aa 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Update snapshots
84640ce 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix tests failing due to overriding getters
c244e9f 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix tests
b6b1fef 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix spelling mistake in describe
d1d0467 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix failing deep linking router test
a3a705c 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fix lint again
23a0465 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@jansav
Copy link
Contributor

jansav commented Mar 7, 2023 •
edited

I was thinking that do we want to do this because it opens up a possibility to regressions and even if we would do it, we would have to extract stuff to own Features. So what I'm suggesting, is that we would start extracting immediately, one by one and after everything is extracted, we remove the bootstrap. In my opinion, it would be easier to control and wouldn't lead to massive PRs because we can create one for introducing the Feature and one for removing the old implementation and switching to use the Feature. WDYT?

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Mar 7, 2023

Okay sure we can do that. I'll close this PR then.

@Nokel81 Nokel81 closed this Mar 7, 2023
@Nokel81 Nokel81 deleted the fully-cleanup-boostrap branch March 7, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansav jansav Awaiting requested review from jansav jansav was automatically assigned from lensapp/lens-ide

@Iku-turso Iku-turso Awaiting requested review from Iku-turso Iku-turso was automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nokel81 @jansav