Introduce package for Features #7242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansav
requested review from
Nokel81 and
aleksfront
and removed request for
a team
jansav
force-pushed
the
feat/feature-core
branch
from
bd44f66
to
682ea6f
Compare
ixrock
previously approved these changes
Feb 27, 2023
packages/technical-features/feature-core/src/registration-of-feature.test.ts
Show resolved
Hide resolved
Comment on lines
+15
to
+19
| const registerFeatureRecursed = ( | ||
| di: DiContainer, | ||
| feature: Feature, | ||
| dependedBy?: Feature | ||
| ) => { |
There was a problem hiding this comment.
nit: this is more readable imho + there is no actual reason to use arrow-function, this context is not even considered).
Suggested change
| const registerFeatureRecursed = ( | |
| di: DiContainer, | |
| feature: Feature, | |
| dependedBy?: Feature | |
| ) => { | |
| function registerFeatureRecursed(di: DiContainer, feature: Feature, dependedBy?: Feature) { |
jansav
force-pushed
the
feat/feature-core
branch
from
682ea6f
to
275adee
Compare
Nokel81
reviewed
Feb 27, 2023
|
|
||
| #### NPM packages exporting a Feature | ||
| - Prefer `peerDependencies` since they are installed from the application and are not allowed to be in the built bundle. | ||
| - Prefer exporting `injectionToken` instead of `injectable` for not allowing other features to access technical details like the `injectable` |
There was a problem hiding this comment.
Can the example above show this then. Not the best if the best practice is not shown in the only example code.
There was a problem hiding this comment.
That's just example which shows how Feature is created. We will have scaffolding for Features which will demonstrate both bullet points. And link for that will be updated here.
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
jansav
force-pushed
the
feat/feature-core
branch
from
275adee
to
5f01374
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
feature-corepackage will allow us to start extending the application without relying current Extension API.Expect future PRs to showcase usage.