New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
White-listing of telemetry params #7262
Conversation
This was not used, and would make development of future feature more difficult. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
…nd not blow up fatally Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
682050b
to
7855271
Compare
@@ -8,6 +8,7 @@ import loggerInjectable from "./logger.injectable"; | |||
const logErrorInjectable = getInjectable({ | |||
id: "log-error", | |||
instantiate: (di) => di.inject(loggerInjectable).error, | |||
decorable: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you describe what decorable
is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a solution to make decorators
, and their affiliates, not decorate themselves infinitely. We'll remove requirement for decorable
eventually.
Any advice where whitelisting params should be implemented very first? |
@aleksfront I suppose we could follow the white-list in Eg. |
* Drop support for adding telemetry by tagging This was not used, and would make development of future feature more difficult. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Introduce white-listing for params of telemetry Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix linting Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make misconfigured telemetry for function parameters log the error, and not blow up fatally Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> --------- Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* White-listing of telemetry params (#7262) * Drop support for adding telemetry by tagging This was not used, and would make development of future feature more difficult. Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Introduce white-listing for params of telemetry Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Fix linting Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make misconfigured telemetry for function parameters log the error, and not blow up fatally Co-authored-by: Janne Savolainen <janne.savolainen@live.fi> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> --------- Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Release 6.4.5 Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> --------- Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Motivation: make unexpected large params not eat resources.
With this, we can have white-list such as:
Note: also telemetry by tagging is dropped for not being used.