UI should show resource if cluster is missing allowedResources data #7274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
msa0311
approved these changes
Mar 3, 2023
jansav
approved these changes
Mar 3, 2023
Iku-turso
approved these changes
Mar 3, 2023
aleksfront
approved these changes
Mar 3, 2023
Iku-turso
pushed a commit
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Iku-turso
pushed a commit
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Merged
Iku-turso
added a commit
that referenced
this pull request
Mar 3, 2023
* should show resource if missing allowedResources data (#7274) Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> * Release 6.4.1 Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> --------- Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> Co-authored-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the cluster allowedResources ends up being empty (because of an unknown error?) which will cause UX issue for users because they cannot see for example all Workloads menus. This PR changes the behaviour so that we always show a resource if we didn't get the allowedResources data properly.