Fix request namespace list permissions check if a list rule is not the first match

[jakolehm]

Smaller version of #7280 .

[Iku-turso]

Using asyncFn for stuff like this would remove a bit of duplication :)

[jakolehm]

Maybe give an example and I'll refactor? :)

[Iku-turso]

An example on adding asyncFn to existing code structure. Note that the different parts of code here can be spread in different beforeEach to remove said duplication.

const createSelfSubjectRulesReviewMock = asyncFn();

const proxyConfigStub = createProxyConfigStub(createSelfSubjectRulesReviewMock);

const requestPermissions = requestNamespaceListPermissions(proxyConfigStub);

const permissionCheckPromise = requestPermissions("some-namespace");

// Note: in different test, this could be `.reject(...)`.
createSelfSubjectRulesReviewMock.resolve({
  body: {
    status: {
      incomplete: true,
      resourceRules: [],
      nonResourceRules: [],
    },
  },
});

const permissionCheck = await permissionCheckPromise;

expect(permissionCheck({
  apiName: "pods",
  group: "",
  kind: "Pod",
  namespaced: true,
})).toBeTruthy();

[Iku-turso]

To consolidate communication in future, this is a stub instead of fake :)

A fake is a trusted simulation of something with non-trivial implementation. A stub is a trivial substitution of value.

[jakolehm]

Changed.

[Iku-turso]

A string value that does not affect test passing or failing should be "irrelevant" or "irrelevant-namespace".

[jakolehm]

Changed.

[Iku-turso]

If injection of dependencies were done using injectables instead of configuring curried functions manually, we could get rid of many steps of test initialisation here, namely everything but override of createSelfSubjectRulesReviewInjectable, (for which that would asyncFn fit nicely).

[Iku-turso]

Example:

const createSelfSubjectRulesReviewMock = asyncFn();

di.override(createSelfSubjectRulesReviewInjectable, () => createSelfSubjectRulesReviewMock);

const requestNamespaceListPermissions = di.inject(requestNamespaceListPermissionsInjectable);

[jakolehm]

I agree that the implementation could be simplified a lot but I'm not comfortable doing that in this PR.