Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better displaying container's info for Pods #7331

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Better displaying container's info for Pods #7331

merged 3 commits into from
Mar 10, 2023

Conversation

ixrock
Copy link
Member

@ixrock ixrock commented Mar 9, 2023 •
edited

Before

Screenshot 2023-03-09 at 17 43 32

image

After

Screenshot 2023-03-09 at 18 15 13

Screenshot 2023-03-09 at 18 48 25

@ixrock ixrock added the enhancement New feature or request label Mar 9, 2023
@ixrock ixrock requested a review from a team as a code owner March 9, 2023 16:35
@ixrock ixrock self-assigned this Mar 9, 2023
@ixrock ixrock requested review from Nokel81 and jim-docker and removed request for a team March 9, 2023 16:35
@ixrock ixrock added this to the 6.5.0 milestone Mar 9, 2023
@ixrock ixrock force-pushed the fix/pod_containers_tooltip branch from e1bcb41 to 2995ca7 Compare March 9, 2023 16:43
@ixrock
Better displaying container's info for Pods and all tooltips with `fo…
cebde0d 
…rmatters={{tableView: true}}`

Signed-off-by: Roman <ixrock@gmail.com>
@ixrock ixrock force-pushed the fix/pod_containers_tooltip branch from 2995ca7 to cebde0d Compare March 9, 2023 16:48
jim-docker
jim-docker previously approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate that for a terminated container the container id is still wrapped, last few characters don't make it on the first line.

@ixrock
fix: keep containerID on a single line
d11948c 
Signed-off-by: Roman <ixrock@gmail.com>
@ixrock
Copy link
Member Author

ixrock commented Mar 9, 2023

It's a bit unfortunate that for a terminated container the container id is still wrapped, last few characters don't make it on the first line.

Now should be fine:

Screenshot 2023-03-09 at 23 36 44

Nodes:

Screenshot 2023-03-09 at 23 42 00

Nokel81
Nokel81 previously approved these changes Mar 9, 2023
View reviewed changes
@jim-docker
Copy link
Contributor

I didn't mean to make more work but this is on linux:

Screen Shot 2023-03-09 at 7 08 07 PM

You probably can't make it perfect.

aleksfront
aleksfront previously approved these changes Mar 10, 2023
View reviewed changes
@ixrock
nope, i can :P (make it perfect)
94d082c 
Signed-off-by: Roman <ixrock@gmail.com>
@ixrock ixrock dismissed stale reviews from aleksfront and Nokel81 via 94d082c March 10, 2023 12:18
@ixrock
Copy link
Member Author

ixrock commented Mar 10, 2023

I didn't mean to make more work but this is on linux:
You probably can't make it perfect.

PTAL. now even alignment for the first column should be always to the right.

Screenshot 2023-03-10 at 14 13 16

Screenshot 2023-03-10 at 14 13 27

@Nokel81 Nokel81 merged commit 34aed58 into master Mar 10, 2023
@Nokel81 Nokel81 deleted the fix/pod_containers_tooltip branch March 10, 2023 13:34
@Nokel81 Nokel81 mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nokel81 Nokel81 Nokel81 approved these changes

@aleksfront aleksfront aleksfront left review comments

@jim-docker jim-docker jim-docker left review comments

Assignees

@ixrock ixrock

Labels
enhancement New feature or request
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ixrock @jim-docker @Nokel81 @aleksfront