Fix resolveSystemProxyFromElectron causing a crash on quit #7379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
jakolehm
requested review from
jansav and
Iku-turso
and removed request for
a team
jakolehm
commented
Mar 20, 2023
| import { BrowserWindow } from "electron"; | ||
|
|
||
| const electronBrowserWindowInjectable = getInjectable({ | ||
| id: "electron-browser-window", | ||
| const resolveSystemProxyWindowInjectable = getInjectable({ |
There was a problem hiding this comment.
Changed because we really need a very specific instance (this is not a generic electron BrowserWindow).
jakolehm
commented
Mar 20, 2023
| return (opts: BrowserWindowConstructorOptions) => { | ||
| return new BrowserWindow(opts); | ||
| }; | ||
| return new BrowserWindow({ show: false, paintWhenInitiallyHidden: false }); |
There was a problem hiding this comment.
paintWhenInitiallyHidden: false is the actual fix.
Nokel81
approved these changes
Mar 20, 2023
gabriel-mirantis
pushed a commit
that referenced
this pull request
Mar 21, 2023
* destroy resolve system proxy window on before quit Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> * resolve system proxy window: load blank page Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> * disable paintWhenInitiallyHidden Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> --------- Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> Signed-off-by: Gabriel <gaccettola@mirantis.com>
Nokel81
pushed a commit
that referenced
this pull request
Mar 22, 2023
* destroy resolve system proxy window on before quit Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> * resolve system proxy window: load blank page Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> * disable paintWhenInitiallyHidden Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> --------- Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Merged
Nokel81
added a commit
that referenced
this pull request
Mar 22, 2023
* Fix resolve system proxy error when no windows available (#7375) * fix resolve system proxy error when no windows available Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> * fix electronBrowserWindowInjectable id Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> --------- Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix resolveSystemProxyFromElectron causing a crash on quit (#7379) * destroy resolve system proxy window on before quit Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> * resolve system proxy window: load blank page Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> * disable paintWhenInitiallyHidden Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> --------- Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> * Release 6.4.8 Signed-off-by: Sebastian Malton <sebastian@malton.name> --------- Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> Signed-off-by: Sebastian Malton <sebastian@malton.name> Co-authored-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7378