Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron 22.3.3 #7389

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Electron 22.3.3 #7389

merged 5 commits into from
Mar 21, 2023

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Mar 21, 2023 •
edited
Loading

Note:

Electron will be ending support for Windows 7/8/8.1 after version 22.x.y following Chromium's plan to end support. Older versions of Electron will continue to work, but no further updates will be made for these operating systems.

@jakolehm jakolehm added dependencies Pull requests that update a dependency file area/security labels Mar 21, 2023
@jakolehm jakolehm added this to the 6.5.0 milestone Mar 21, 2023
@jakolehm jakolehm requested a review from a team as a code owner March 21, 2023 06:05
@jakolehm jakolehm requested review from jansav and jim-docker and removed request for a team March 21, 2023 06:05
@jakolehm jakolehm marked this pull request as draft March 21, 2023 06:45
@jakolehm jakolehm marked this pull request as ready for review March 21, 2023 07:14
aleksfront
aleksfront previously approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jakolehm @Nokel81
electron 22.3.3.
77a44f4 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm @Nokel81
fix typo
caf9729 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm @Nokel81
fix crash on quit
f63ce7b 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm @Nokel81
fix sessionData app path
b116298 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Nokel81
Nokel81 previously approved these changes Mar 21, 2023
View reviewed changes
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Nokel81
Fix errors after merging new feature
8bee932 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
Nokel81 reviewed Mar 21, 2023
View reviewed changes
packages/core/src/common/app-paths/app-path-names.ts
@@ -11,7 +11,7 @@ export const pathNames: PathName[] = [
"home",
"appData",
"userData",
"cache",
"sessionData",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we get a type error without 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Nokel81 Nokel81 merged commit a920f2c into master Mar 21, 2023
@Nokel81 Nokel81 deleted the electron-22.3.3 branch March 21, 2023 15:07
@Nokel81 Nokel81 mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nokel81 Nokel81 Nokel81 approved these changes

@aleksfront aleksfront aleksfront left review comments

@jansav jansav Awaiting requested review from jansav jansav is a code owner automatically assigned from lensapp/lens-ide

@jim-docker jim-docker Awaiting requested review from jim-docker jim-docker is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
area/security dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakolehm @Nokel81 @aleksfront