Allow user to select Kubeconfig from filesystem #740

ixrock · 2020-08-24T16:26:34Z

close #738

Signed-off-by: Roman <ixrock@gmail.com>

jakolehm · 2020-08-24T17:43:08Z

src/renderer/components/input/file-input.tsx

+  render() {
+    const { onSelectFiles, readAsText, ...props } = this.props;
+    return (
+      <input


Can we somehow set a directory here? It would make sense to open a file dialog to a path where default kubeconfig is located (thanks @matti for this tip).

Have to check if it's possible with standard <input type="file"> system dialog to customize it somehow.

Can't find anything appropriate for https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file

It's not normally allowed because of browser security issues. Electron could have an extension to this behaviour because it also allows to read local files (which browsers don't allow).

Could we use this? https://www.electronjs.org/docs/api/dialog#dialogshowopendialogbrowserwindow-options

aleksfront

Also, is it possible to show hidden files and folders in upload dialog? It's impossible to go to some paths because of that.

src/renderer/components/+add-cluster/add-cluster.scss

jakolehm

LGTM. We probably should open an issue about using electron's showOpenDialog (instead of input).

aleksfront · 2020-08-25T06:24:34Z

An idea (out of the scope): should we also allow to drop kubeconfig files from filesystem right into this "input"?

jakolehm · 2020-08-25T06:25:05Z

Also, is it possible to show hidden files and folders in upload dialog? It's impossible to go to some paths because of that.

That's why we should open the default kubeconfig location by default (because it's a hidden folder and not easily accessible on MacOS).

jakolehm · 2020-08-25T06:28:03Z

An idea (out of the scope): should we also allow to drop kubeconfig files from filesystem right into this "input"?

Good idea!

src/renderer/components/+add-cluster/add-cluster.tsx

jakolehm · 2020-08-25T06:32:00Z

Also, is it possible to show hidden files and folders in upload dialog? It's impossible to go to some paths because of that.

That's why we should open the default kubeconfig location by default (because it's a hidden folder and not easily accessible on MacOS).

Actually it's possible to show hidden files/folders with https://www.electronjs.org/docs/api/dialog#dialogshowopendialogbrowserwindow-options . Anyway, we should still open a dialog to a folder where current kubeconfig is.

ixrock · 2020-08-25T07:54:58Z

BTW it's possible to show hidden files in finder in MacOS with Cmd+Shift+.

Co-authored-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>

Co-authored-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Roman <ixrock@gmail.com>

ixrock · 2020-08-25T11:03:53Z

New select files system dialog:

Drag-n-drop custom kube-config:

jakolehm · 2020-08-25T11:08:35Z

@ixrock awesome! Could you make DCO bot happy so that we can merge this asap?

miskun · 2020-08-25T11:13:52Z

UI needs improvement. The feature itself is good.

jakolehm · 2020-08-25T11:17:02Z

UI needs improvement. The feature itself is good.

@miskun let's create a separate issue about this.

Signed-off-by: Roman <ixrock@gmail.com>

… kube-config file Signed-off-by: Roman <ixrock@gmail.com>

…auto-replace "~" => os.homedir() Signed-off-by: Roman <ixrock@gmail.com>

ixrock · 2020-08-25T20:25:40Z

Latest design. Wdyt?

Customized kube-config file view:
Icons at the right: Reset and Browse

Custom config tab:
Should we customize height/position of the editor somehow?

Dropping kube-config file in case of invalid file

ixrock · 2020-08-25T20:32:55Z

One more question: in case of using second tab with custom kube-config text: should we still use "Select context" form-control or hide it and instead consume all clusters and contexts from pasted config?

aleksfront · 2020-08-26T06:30:43Z

Can you replace kube-config in tab and in Pro-tip to just kubeconfig. K8S docs are using latest notation.

aleksfront · 2020-08-26T06:33:57Z

One more question: in case of using second tab with custom kube-config text: should we still use "Select context" form-control or hide it and instead consume all clusters and contexts from pasted config?

My suggestion is:
Select kubeconfig file tab - leave as is but remove Custom option from context selector.
Paste as text tab - remove context selector completely and create all pasted clusters.

matti · 2020-08-26T15:54:51Z

umm, if the config has a lot of contexts it will take about an hour with the current "how to remove cluster from lens" - it is a LOT of clicking. And I think doing that kind of thing "add all clusters" is horribly wrong decission anyway. The user is doing "add cluster" - not "add clusterS"

jakolehm · 2020-08-26T16:03:50Z

umm, if the config has a lot of contexts it will take about an hour with the current "how to remove cluster from lens" - it is a LOT of clicking. And I think doing that kind of thing "add all clusters" is horribly wrong decission anyway. The user is doing "add cluster" - not "add clusterS"

Good point, thanks @matti !

Signed-off-by: Roman <ixrock@gmail.com>

ixrock · 2020-08-26T17:25:04Z

Initial view

Adding clusters from non-default kubeconfig file

Adding clusters from pasted kubeconfig

Signed-off-by: Roman <ixrock@gmail.com>

nevalla · 2020-08-27T05:35:34Z

I think it's now pre-selects all contexts found in kubeconfig. That might be fine if there's only one context but if there are hundreds of contexts it's not good idea.

nevalla · 2020-08-27T05:39:30Z

When adding clusters from kubeconfig file, we don't want to save kubeconfig under app resources but we want to keep the reference to the original kubeconfig file. If pasting kubeconfig, then we store kubeconfig like we do it already.

nevalla · 2020-08-27T07:06:19Z

Please could you run git rebase HEAD~11 --signoff to make DCO happy.

nevalla · 2020-08-27T07:45:28Z

When adding clusters from kubeconfig file, we don't want to save kubeconfig under app resources but we want to keep the reference to the original kubeconfig file. If pasting kubeconfig, then we store kubeconfig like we do it already.

That said, we need to unlink kubeconfig file on cluster remove only if kubeconfig file is stored in app resources.

ixrock · 2020-08-27T08:14:27Z

When adding clusters from kubeconfig file, we don't want to save kubeconfig under app resources but we want to keep the reference to the original kubeconfig file. If pasting kubeconfig, then we store kubeconfig like we do it already.

What happens if file is damaged or added context will be removed from original kubeconfig file at some point?

- remove only custom embed kubeconfig files - keep link to original kubeconfig file when added via file - remove auto-select all contexts from kubeconfig source Signed-off-by: Roman <ixrock@gmail.com>

Signed-off-by: Roman <ixrock@gmail.com>

…stom_config # Conflicts: # src/common/cluster-store.ts # src/migrations/cluster-store/3.6.0-beta.1.ts

Signed-off-by: Roman <ixrock@gmail.com>

ixrock · 2020-08-27T10:35:57Z

@nevalla ready to merge, please check.
FYI: auto-selecting contexts enabled when up to 10 contexts available from kubeconfig source for now.

nevalla · 2020-08-27T13:17:51Z

src/common/vars.ts

@@ -5,7 +5,7 @@ import { defineGlobal } from "./utils/defineGlobal";

 export const isMac = process.platform === "darwin"
 export const isWindows = process.platform === "win32"
-export const isDebugging = process.env.DEBUG === "true";
+export const isDebugging = process.env.DEBUG === "lens";


please revert this and let's focus on this in separate PR

Signed-off-by: Roman <ixrock@gmail.com>

nevalla · 2020-08-27T13:22:28Z

FYI: auto-selecting contexts enabled when up to 10 contexts available from kubeconfig source for now.

I'm not sure about this. I have one context in default kubeconfig that I don't ever want to add to Lens. Now it's always auto-selected when adding new clusters. @jakolehm WDYT?

ixrock · 2020-08-27T13:24:23Z

FYI: auto-selecting contexts enabled when up to 10 contexts available from kubeconfig source for now.

I'm not sure about this. I have one context in default kubeconfig that I don't ever want to add to Lens. Now it's always auto-selected when adding new clusters. @jakolehm WDYT?

Well you can de-select manually. But for most cases auto-selection is good IMO.

jakolehm · 2020-08-27T13:31:03Z

FYI: auto-selecting contexts enabled when up to 10 contexts available from kubeconfig source for now.

I'm not sure about this. I have one context in default kubeconfig that I don't ever want to add to Lens. Now it's always auto-selected when adding new clusters. @jakolehm WDYT?

IMHO auto-selection is not a good idea. I have had times when I have huge number of clusters in kubeconfig and normally I always just want to get one cluster from there.

Signed-off-by: Roman <ixrock@gmail.com>

nevalla

LGTM

Allow user to select Kubeconfig from filesystem, fix #738

f067152

Signed-off-by: Roman <ixrock@gmail.com>

ixrock requested a review from a team August 24, 2020 16:26

jakolehm added area/ui enhancement New feature or request labels Aug 24, 2020

jakolehm added this to the 3.6.0 milestone Aug 24, 2020

jakolehm reviewed Aug 24, 2020

View reviewed changes

aleksfront reviewed Aug 25, 2020

View reviewed changes

src/renderer/components/+add-cluster/add-cluster.scss Outdated Show resolved Hide resolved

jakolehm approved these changes Aug 25, 2020

View reviewed changes

jakolehm reviewed Aug 25, 2020

View reviewed changes

src/renderer/components/+add-cluster/add-cluster.tsx Outdated Show resolved Hide resolved

ixrock and others added 4 commits August 25, 2020 10:56

Update src/renderer/components/+add-cluster/add-cluster.tsx

5a14e9f

Co-authored-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>

Update src/renderer/components/+add-cluster/add-cluster.scss

16e5055

Co-authored-by: Alex Andreev <alex.andreev.email@gmail.com>

use dialog.showOpenDialog for selecting custom kube-config file

8c14513

Signed-off-by: Roman <ixrock@gmail.com>

enable drag-n-drop for custom kube-config file

843a687

Signed-off-by: Roman <ixrock@gmail.com>

ixrock added 3 commits August 25, 2020 17:15

reworks -- part 1

a5e5a4c

Signed-off-by: Roman <ixrock@gmail.com>

replaced browse/reset buttons to icons, extended drop area for custom…

cb669d1

… kube-config file Signed-off-by: Roman <ixrock@gmail.com>

allow to manually input kube-config file path (edit + save on blur + …

bec50de

…auto-replace "~" => os.homedir() Signed-off-by: Roman <ixrock@gmail.com>

ixrock added 2 commits August 26, 2020 20:11

fixes

56d1806

Signed-off-by: Roman <ixrock@gmail.com>

more fixes

c73bd78

Signed-off-by: Roman <ixrock@gmail.com>

fix unit tests

33b7bfa

Signed-off-by: Roman <ixrock@gmail.com>

ixrock added 4 commits August 27, 2020 12:57

fixes:

b698b7f

- remove only custom embed kubeconfig files - keep link to original kubeconfig file when added via file - remove auto-select all contexts from kubeconfig source Signed-off-by: Roman <ixrock@gmail.com>

auto-select contexts up to 10, main-layout small fix

17185cd

Signed-off-by: Roman <ixrock@gmail.com>

Merge remote-tracking branch 'origin/master' into add_cluster_from_cu…

01be6e4

…stom_config # Conflicts: # src/common/cluster-store.ts # src/migrations/cluster-store/3.6.0-beta.1.ts

master-merge fixes

23e82c8

Signed-off-by: Roman <ixrock@gmail.com>

ixrock requested a review from nevalla August 27, 2020 11:20

ixrock mentioned this pull request Aug 27, 2020

Remove cluster view on cluster remove #758

Merged

nevalla requested changes Aug 27, 2020

View reviewed changes

revert process.env.DEBUG to "true"

4b5a4d8

Signed-off-by: Roman <ixrock@gmail.com>

remove auto-select clusters, clean up

55bb573

Signed-off-by: Roman <ixrock@gmail.com>

nevalla approved these changes Aug 27, 2020

View reviewed changes

nevalla merged commit b8994a4 into master Aug 28, 2020

nevalla deleted the add_cluster_from_custom_config branch August 28, 2020 05:43

This was referenced Aug 28, 2020

Release v3.6.0-beta.1 #762

Merged

Fix integration tests #767

Merged

nevalla mentioned this pull request Sep 4, 2020

Kube config is not found on Windows #599

Closed

nevalla mentioned this pull request Sep 14, 2020

Release v3.6.0 #870

Merged

Allow user to select Kubeconfig from filesystem #740

Allow user to select Kubeconfig from filesystem #740

Conversation

ixrock commented Aug 24, 2020 • edited

jakolehm Aug 24, 2020

Choose a reason for hiding this comment

ixrock Aug 24, 2020

Choose a reason for hiding this comment

ixrock Aug 24, 2020

Choose a reason for hiding this comment

jakolehm Aug 25, 2020

Choose a reason for hiding this comment

jakolehm Aug 25, 2020

Choose a reason for hiding this comment

aleksfront left a comment

Choose a reason for hiding this comment

jakolehm left a comment

Choose a reason for hiding this comment

aleksfront commented Aug 25, 2020

jakolehm commented Aug 25, 2020

jakolehm commented Aug 25, 2020

jakolehm commented Aug 25, 2020

ixrock commented Aug 25, 2020 • edited

ixrock commented Aug 25, 2020

jakolehm commented Aug 25, 2020

miskun commented Aug 25, 2020

jakolehm commented Aug 25, 2020

ixrock commented Aug 25, 2020 • edited

Latest design. Wdyt?

ixrock commented Aug 25, 2020 • edited

aleksfront commented Aug 26, 2020

aleksfront commented Aug 26, 2020

matti commented Aug 26, 2020

jakolehm commented Aug 26, 2020

ixrock commented Aug 26, 2020

nevalla commented Aug 27, 2020

nevalla commented Aug 27, 2020

nevalla commented Aug 27, 2020

nevalla commented Aug 27, 2020

ixrock commented Aug 27, 2020 • edited

ixrock commented Aug 27, 2020 • edited

nevalla Aug 27, 2020

Choose a reason for hiding this comment

ixrock Aug 27, 2020

Choose a reason for hiding this comment

nevalla commented Aug 27, 2020

ixrock commented Aug 27, 2020

jakolehm commented Aug 27, 2020

nevalla left a comment

Choose a reason for hiding this comment

ixrock commented Aug 24, 2020 •

edited

ixrock commented Aug 25, 2020 •

edited

ixrock commented Aug 25, 2020 •

edited

ixrock commented Aug 25, 2020 •

edited

ixrock commented Aug 27, 2020 •

edited

ixrock commented Aug 27, 2020 •

edited