Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace StatusBar bgcolor from --colorInfo to --primary #7738

Merged
merged 1 commit into from May 17, 2023

Conversation

aleksfront
Copy link
Contributor

var(--colorInfo) is a bit different between light and dark theme. While var(--primary) stays same.

primary color for status bar

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront added bug Something isn't working area/ui labels May 17, 2023
@aleksfront aleksfront added this to the 6.5.0 milestone May 17, 2023
@aleksfront aleksfront requested a review from ixrock May 17, 2023 08:43
@aleksfront aleksfront requested a review from a team as a code owner May 17, 2023 08:43
@aleksfront aleksfront requested review from jim-docker and removed request for a team May 17, 2023 08:43
@@ -13,7 +13,7 @@

display: inline-grid;
grid-template-columns: 1fr 1fr;
background-color: var(--colorInfo);
background-color: var(--primary);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's intended --colorInfo variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All colors needs to be reviewed and cleaned up.

@aleksfront aleksfront merged commit 2dfb5c0 into master May 17, 2023
17 checks passed
@aleksfront aleksfront deleted the fix-status-bar-background-color branch May 17, 2023 11:26
@Nokel81 Nokel81 mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants