fix: Remove erroneous prefixes when using loggerInjectable and prefixLoggerInjectable #7745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LoggerInjectable Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
requested review from
jansav and
jim-docker
and removed request for
a team
jim-docker
approved these changes
May 19, 2023
| (di: DiContainerForInjection): LogFunction => { | ||
| const getLogFunctionFor = (scenario: keyof Logger, namespace: string | undefined) => { | ||
| const prefix = namespace | ||
| ? `[${screamingKebabCase(namespace.replace(/-feature$/, ""))}]: ` |
There was a problem hiding this comment.
we assume the id or namespace is lowercase?
There was a problem hiding this comment.
If somebody called their feature "my-feature"?
There was a problem hiding this comment.
Yeah I did assume that given that all of them are. I can make a follow-up PR to fix this
This was referenced May 23, 2023
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7744