Fixing Dialog Escape keypress behavior #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Nokel81
approved these changes
Sep 9, 2020
ixrock
reviewed
Sep 9, 2020
| @@ -92,15 +92,15 @@ export class Dialog extends React.PureComponent<DialogProps, DialogState> { | |||
| this.props.onOpen(); | |||
| if (!this.props.pinned) { | |||
| if (this.elem) this.elem.addEventListener('click', this.onClickOutside); | |||
| window.addEventListener('keydown', this.onEscapeKey); | |||
| document.body.addEventListener('keydown', this.onEscapeKey); | |||
There was a problem hiding this comment.
Please add comment (to the code) why document.body is used and how it's related to Drawer's event(s).
ixrock
approved these changes
Sep 9, 2020
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing to close Dialog only (not along with opened Drawer) after hitting Esc key. Made by changed
keypresstarget -document.bodyis located 'lower' in event bubbling stairs so it will fire event earlier than Drawer.Fixes #757
Signed-off-by: Alex Andreev alex.andreev.email@gmail.com