Fix cluster's apiUrl #846
Merged
Fix cluster's apiUrl #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksfront
reviewed
Sep 10, 2020
src/main/cluster.ts
Outdated
| @@ -82,8 +82,7 @@ export class Cluster implements ClusterModel { | |||
| @action | |||
| updateModel(model: ClusterModel) { | |||
| Object.assign(this, model); | |||
| this.apiUrl = this.getKubeconfig().getCurrentCluster()?.server; | |||
| this.contextName = this.contextName || this.preferences.clusterName; | |||
| this.apiUrl = this.getKubeconfig().getCluster(this.getKubeconfig().getContextObject(this.contextName).cluster).server | |||
There was a problem hiding this comment.
Maybe it's better to move this.getKubeconfig() into some const before this line to avoid parsing kubeconfig twice.
There was a problem hiding this comment.
Done. Also moved this assign into constructor, since it's not going to change.
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
nevalla
force-pushed
the
fix/cluster-api-url
branch
from
a743c53
to
1438273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #845
Signed-off-by: Lauri Nevala lauri.nevala@gmail.com