App reload in cluster settings #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
requested changes
Sep 11, 2020
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
approved these changes
Sep 11, 2020
| path: [clusterViewRoute.path, clusterSettingsRoute.path].flat(), | ||
| exact: true | ||
| }) | ||
| const isActive = activeClusterId === cluster.id && !!matched; |
There was a problem hiding this comment.
Why do we need to check route matching to highlight cluster icon?
const isActive = cluster.id === clusterStore.activeClusterId not enough?
There was a problem hiding this comment.
Btw, in case of using matchPath should be like const isActive = cluster.id === matched?.params.clusterId in your case.. but I suggest to remove it if no objections..
There was a problem hiding this comment.
Made suggested changes and completely removed matchPath.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply whole
webContentsreload in Cluster Settings.Resolves #796
Signed-off-by: Alex Andreev alex.andreev.email@gmail.com