Lens profile for Olympus 12-45 f/4 PRO #1345
Comments
|
I've purchased that lens recently. I've tried to patch your correction into data/db/mil-olympus.xml and build a package (Arch Linux). Darktable fails to detect that lens. It seems that exiv2 doesn't know anything about it yet: so "exiv2 -pt some_foo.ORF | grep -ai lens" reports back only See this Exiv2 issue report and how to get it reported properly until a new release happens. But even with the proper lens recognition I couldn't get darktable to apply your lens corrections. No idea what's wrong with that patch even with properly matching lens name: Could you menage to actually use your corrections? Once this has been sorted out you should try to file a PR. |
|
I use my correction with RawTherapee and it works. Are you sure that Darktable is not using a copy of lensfun from another folder? You can make a simple test: open an image taken with a different lens and check that DarkTable recognizes it. Then edit the lenfun file and change the lens name to something different. Now open again the same image: if DartTable still recognizes the lens it means that it is loading lensfun from somewhere else. Of course remember to restore the lens name in the xml file. I don't think that Exiv2 is needed to correct the lens. Isn't it just for metadata? By the way, the Olympus is a very good lens but it has large sample variations. The first copy that I received was defective: the right side of the images was never sharp. You can check such problems in a simple way: |
When you've ever used "lensfun-update-data" either as user or root to update the lensfun db that's preferred over /usr/share/lensfun/version_2/mil-olympus.xml and even over ~/.local/share/lensfun/newlens.xml it seems. Deleting everything from ~/.local/share/lensfun/updates/* and /var/lib/lensfun-updates/* allows the lens to be detected. I'm going now to actually try your corrections to see if they work as intended. |
|
@fsenore: Please rename the lense in your zip to reflect the exiv2 naming or it won't get detected with new any new exiv2 release and change you local ~/.exiv2 to reflect that naming.
Basic testing shows no issues here. Vignetting and distorsion seems to go away well. I don't yet have a photo with high chromatic aberrations. |
|
There is a problem with the lens name. It looks like the RawTherapee name of the lens is “Olympus M.Zuiko Digital ED 12-45mm f/4.0 Pro” and the Exiv2 name of the same lens is “Olympus M.Zuiko Digital ED 12-45mm F4.0 Pro” Since the names are slightly different I suppose that a lensfun profile cannot work at the same time with RawTherapee and with DarkTable that uses EXiv2 to detect the lens. Moreover both names are different from the one that I read at the Olympus web site: “M.Zuiko Digital ED 12‑45mm F4 PRO” Is the a way to solve this naming problem, or am I missing something? |
|
I've used the official OMDS naming from here and followed all the exiv2 MFT lenses scheme. I guess this is more likely a RawTherapee bug if it doesn't detect that lens name. The Oly 12-40 Pro lens has the same lens naming scheme used in lensfun. |
|
I looked at the Italian site and the lens name was different... |
|
Looks good to me and should be pushed now. |
|
Maybe open a merge request to get it actually merged. It seems issues don't receive that much intention. |
Replace distortion and TCA params with a full set from issue #1345 .
|
correction for the lens is completely included in db |
I have created a profile for the Olympus 12-45 f/4 PRO lens for Micro 4/5. I used Torsten Bronger's phyton script.
Please let me know if you need more information.
Fulvio Senore
lensfun.zip
The text was updated successfully, but these errors were encountered: