-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interference between lensfun and gphoto causes darktable to crash #1984
Comments
jonas-ott
added a commit
to jonas-ott/lensfun
that referenced
this issue
Feb 17, 2023
jonas-ott
added a commit
to jonas-ott/lensfun
that referenced
this issue
Feb 17, 2023
jonas-ott
added a commit
to jonas-ott/lensfun
that referenced
this issue
Feb 17, 2023
jonas-ott
added a commit
to jonas-ott/lensfun
that referenced
this issue
Feb 17, 2023
I see a bit of activity here. Does this mean a resolution to the crash bug in darktable could be forthcoming? Not being a programmer, I'm not sure what the process will be. |
sarunasb
pushed a commit
that referenced
this issue
Mar 1, 2023
jonas-ott
added a commit
to jonas-ott/lensfun
that referenced
this issue
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The original bug submission started with darktable. When darktable completes an import of images, it begins to process thumbnails. During that process, there is a conflict between two dependencies within darktable. One of those dependencies is lensfun. Darktable then crashes.
Below is a link to the crash submission at darktable. It includes a full crash report.
darktable-org/darktable#13637 (comment)
Github member parafin reviewed the crash report, and matched it to the problematic code. I'm not a programmer, so I quote his comments directly below ...
parafin wrote "The crash seems to be caused by lensfun doing setlocale call in thread 6 while gphoto is doing sprintf in thread 11 (which depends on locale). So it's an interference between two darktable dependencies (lensfun and gphoto) due to multi-threading. This has to be fixed upstream in lensfun, it mustn't do setlocale calls, since it's not thread-safe and affects the whole application.
Offending line is here: https://github.com/lensfun/lensfun/blob/release_0.3.x/libs/lensfun/lens.cpp#L253
I suggest to report it to lensfun."
I hope this submission is helpful.
The text was updated successfully, but these errors were encountered: