Fix checking Windows platform for non-msvc toolchain #1999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes _MSC_VER with PLATFORM_WINDOWS macro to check Windows platform. _MSC_VER is specific for MSVC toolchain and not defined in mingw based toolchain. So, this fixes compilation in later one. bd4c56c introduces the issue.
|
I'm relatively new to this github, compiling, and linux... If it's become "commit" ... how long before the actual source code is updated with this change? |
|
Modifying the database.cpp and lens.cpp files, with the suggested changes, resolved the issue for me... Thank you!!! |
This was referenced Mar 24, 2023
Closed
|
@sarunasb Any chance of a merge on this one? It's simple and will mean less issues being opened about building on Windows :) |
|
Fixed by 6cb00f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1998