Stop using INT_MIN/INT_MAX for floats #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INT_MIN/INT_MAX are meant for the int type, and thus casting them to a different type (float) means loss of precision which may lead to failed comparisons later on. Instead use the proper limits using std::numeric_limits.
pinotree
added a commit
to pinotree/lensfun
that referenced
this pull request
Aug 18, 2023
INT_MIN/INT_MAX are meant for the int type, and thus casting them to a different type (float) means loss of precision which may lead to failed comparisons later on. Instead use the proper limits using std::numeric_limits. (cherry picked from commit e1fc29f)
sarunasb
pushed a commit
that referenced
this pull request
Aug 23, 2023
INT_MIN/INT_MAX are meant for the int type, and thus casting them to a different type (float) means loss of precision which may lead to failed comparisons later on. Instead use the proper limits using std::numeric_limits. (cherry picked from commit e1fc29f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT_MIN/INT_MAXare meant for theinttype, and thus casting them to a different type (float) means loss of precision which may lead to failed comparisons later on.Instead use the proper limits using
std::numeric_limits.