-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add macOS job #2159
base: master
Are you sure you want to change the base?
CI: add macOS job #2159
Conversation
99968b1
to
38649cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
While you are at it could you also upgrade actions/setup-python@v4
to v5 in .github/workflows/cmake-windows.yml
to fix the Node.js 16 deprecation warning?
Done. |
You could also consider enabling automatic action updates: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates |
f1a9c94
to
5a40df2
Compare
Runs on 'macos-14' explicitly to test arm64 architecture ('macos-latest' is still 'macos-12', which is on x86_64).