Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add macOS job #2159

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CI: add macOS job #2159

wants to merge 3 commits into from

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Feb 2, 2024

Runs on 'macos-14' explicitly to test arm64 architecture ('macos-latest' is still 'macos-12', which is on x86_64).

@kmilos kmilos force-pushed the patch-3 branch 2 times, most recently from 99968b1 to 38649cc Compare February 2, 2024 15:11
Copy link
Contributor

@jonas-ott jonas-ott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

While you are at it could you also upgrade actions/setup-python@v4 to v5 in .github/workflows/cmake-windows.yml to fix the Node.js 16 deprecation warning?

@kmilos
Copy link
Contributor Author

kmilos commented Feb 5, 2024

While you are at it could you also upgrade actions/setup-python@v4 to v5 in .github/workflows/cmake-windows.yml to fix the Node.js 16 deprecation warning?

Done.

@kmilos
Copy link
Contributor Author

kmilos commented Feb 5, 2024

@kmilos kmilos force-pushed the patch-3 branch 2 times, most recently from f1a9c94 to 5a40df2 Compare February 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants