Skip to content

Commit

Permalink
Merge pull request #3 from lenskit/tweak/lkbuild
Browse files Browse the repository at this point in the history
Use LensKit build helpers (#2)
  • Loading branch information
mdekstrand committed Aug 18, 2022
2 parents 7f1366b + 23c9eec commit c66b8ca
Show file tree
Hide file tree
Showing 16 changed files with 10 additions and 286 deletions.
17 changes: 4 additions & 13 deletions .github/workflows/test-suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,11 @@ jobs:
fetch-depth: 0
submodules: true

- name: Prepare Conda environment spec
id: conda-lock
shell: bash
run: |
bash lkbuild/lock-for-ci.sh -v $PYVER
env:
RUNNER: ${{runner.os}}
PYVER: ${{matrix.python}}

- name: Initialize Conda
uses: conda-incubator/setup-miniconda@v2
- name: 👢 Set up Conda environment
uses: lenskit/lkbuild/actions/setup-conda-env@main
id: setup
with:
activate-environment: lkpy
environment-file: ${{steps.conda-lock.outputs.environment-file}}
python-version: ${{matrix.python}}

- name: 🔎 Inspect environment
run: |
Expand Down
Empty file removed lkbuild/__init__.py
Empty file.
11 changes: 0 additions & 11 deletions lkbuild/boot-env.yml

This file was deleted.

60 changes: 0 additions & 60 deletions lkbuild/bootstrap-env.sh

This file was deleted.

33 changes: 0 additions & 33 deletions lkbuild/datasets.py

This file was deleted.

22 changes: 0 additions & 22 deletions lkbuild/env.py

This file was deleted.

10 changes: 0 additions & 10 deletions lkbuild/lock-for-ci.sh

This file was deleted.

4 changes: 0 additions & 4 deletions lkbuild/mkl-spec.yml

This file was deleted.

3 changes: 0 additions & 3 deletions lkbuild/openblas-spec.yml

This file was deleted.

3 changes: 0 additions & 3 deletions lkbuild/python-3.10-spec.yml

This file was deleted.

3 changes: 0 additions & 3 deletions lkbuild/python-3.7-spec.yml

This file was deleted.

3 changes: 0 additions & 3 deletions lkbuild/python-3.8-spec.yml

This file was deleted.

3 changes: 0 additions & 3 deletions lkbuild/python-3.9-spec.yml

This file was deleted.

106 changes: 0 additions & 106 deletions lkbuild/tasks.py

This file was deleted.

8 changes: 4 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ readme = "README.md"
license = { file="LICENSE.md" }
requires-python = ">= 3.7"
dependencies = [
"lenskit[doc] @ git+https://github.com/lenskit/lkpy.git#main",
"lenskit ==0.14.*",
"tensorflow >=2,<2.6"
]
dynamic = ["description", "version"]
Expand All @@ -35,9 +35,8 @@ test = [
"pytest-doctestplus >= 0.9",
]
dev = [
"lenskit-build-helpers >=0.1",
"flit >= 3.2",
"conda-lock",
"invoke",
"flake8 >= 3",
"coverage >= 5",
"pytest-cov >= 2.12",
Expand All @@ -59,5 +58,6 @@ exclude = [

[tool.conda-lock]
channels = [
"conda-forge"
"conda-forge",
"lenskit",
]
10 changes: 2 additions & 8 deletions tests/test_tensorflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,8 @@
import lenskit.util.test as lktu
from lenskit.algorithms import Recommender

from lenskit.algorithms import tf as lktf
try:
import tensorflow as tf
except ImportError:
pytestmark = mark.skip('cannot import tensorflow')

if not lktf.TF_AVAILABLE:
pytestmark = mark.skip('tensorflow not available')
import lenskit_tf as lktf
import tensorflow as tf

_log = logging.getLogger(__name__)

Expand Down

0 comments on commit c66b8ca

Please sign in to comment.