Fix use fo bias in FunkSVD

lenskit · Sep 20, 2018 · 43eafd3 · 43eafd3
1 parent 3bdc564
commit 43eafd3
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lenskit/algorithms/funksvd.py b/lenskit/algorithms/funksvd.py
@@ -74,7 +74,7 @@ def train(self, ratings, bias=None):
         if isinstance(bias, basic.BiasModel):
             gbias = bias.mean
             ibias = bias.items
-            ubias = bias.items
+            ubias = bias.users
         else:
             # we have a single global bias (for e.g. implicit feedback data)
             gbias = bias
@@ -92,7 +92,9 @@ def train(self, ratings, bias=None):
         iidx = pd.Index(ratings.item.unique())
 
         users = uidx.get_indexer(ratings.user).astype(np.int_)
+        assert np.all(users >= 0)
         items = iidx.get_indexer(ratings.item).astype(np.int_)
+        assert np.all(items >= 0)
 
         _logger.debug('computing initial estimates')
         initial = pd.Series(gbias, index=ratings.index, dtype=np.float_)