Merge pull request #283 from mdekstrand/feature/split-tf

Split TensorFlow into a separate package
lenskit · Oct 30, 2021 · 78c0f25 · 78c0f25
2 parents ae37869 + 9699f68
commit 78c0f25
Show file tree

Hide file tree

Showing 14 changed files with 14 additions and 973 deletions.
diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml
@@ -102,61 +102,6 @@ jobs:
 
       - uses: codecov/codecov-action@v1
 
-  check-tf:
-    name: Test TensorFlow on ${{matrix.platform}}
-    timeout-minutes: 30
-    runs-on: ${{matrix.platform}}-latest
-    strategy:
-      matrix:
-        platform:
-          - ubuntu
-          # - windows
-
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
-
-      - name: Prepare Conda environment lock
-        id: conda-lock
-        run: |
-          bash lkbuild/lock-for-ci.sh -v $PYVER -e tf
-        env:
-          PYVER: '3.8'
-
-      - name: Initialize Conda
-        uses: conda-incubator/setup-miniconda@v2
-        with:
-          activate-environment: lktest
-          environment-file: ${{steps.conda-lock.outputs.environment-file}}
-
-      - name: Insepct envonment
-        run: numba -s
-
-      - name: Download ML-100K
-        shell: pwsh
-        run: |
-          ./fetch-datasets.ps1 ml-100k
-
-      - name: Install for Testing
-        run: |
-          flit install -s --deps none
-
-      - name: Run Tests
-        run: |
-          python -m pytest --cov=lenskit --cov-report=xml -k tensorflow --log-file=test.log
-
-      - name: Upload logs
-        uses: actions/upload-artifact@v2
-        with:
-          name: log-tensorflow
-          path: |
-            test*.log
-            emissions.csv
-
-      - name: Upload Coverage
-        uses: codecov/codecov-action@v1
-
   check-docs:
     name: Docs, Examples, and Eval
     timeout-minutes: 30
@@ -319,7 +264,6 @@ jobs:
     needs:
     - conda
     - vanilla
-    - check-tf
     - check-docs
     - mindep
 

diff --git a/docs/addons.rst b/docs/addons.rst
@@ -7,5 +7,6 @@ to implementations in other packages.
 .. toctree::
     :caption: External Algorithms
 
-    Implicit wrappers <https://lkpy.lenskit.org/projects/lenskit-implicit>
+    Implicit wrappers <https://lkpy.lenskit.org/projects/lenskit-implicit/>
     Poisson factorization <https://lkpy.lenskit.org/projects/lenskit-hpf/>
+    TensorFlow algorithms <https://lkpy.lenskit.org/projects/lenskit-tf/>
diff --git a/docs/algorithms.rst b/docs/algorithms.rst
@@ -41,15 +41,6 @@ Matrix Factorization
     als.ImplicitMF
     funksvd.FunkSVD
 
-TensorFlow
-~~~~~~~~~~
-
-.. autosummary::
-
-    tf.BiasedMF
-    tf.IntegratedBiasMF
-    tf.BPR
-
 Add-On Packages
 ~~~~~~~~~~~~~~~
 

diff --git a/docs/index.rst b/docs/index.rst
@@ -53,8 +53,6 @@ Resources
     knn
     mf
     addons
-    tf
-    implicit
 
 .. toctree::
     :maxdepth: 2

diff --git a/docs/tf.rst b/docs/tf.rst
diff --git a/lenskit/algorithms/tf.py b/lenskit/algorithms/tf.py
@@ -0,0 +1,5 @@
+"""
+TensorFlow-based algorithms (legacy imports).
+"""
+
+from lenskit_tf import BiasedMF, IntegratedBiasMF, BPR
diff --git a/lenskit/algorithms/tf/__init__.py b/lenskit/algorithms/tf/__init__.py
diff --git a/lenskit/algorithms/tf/biasedmf.py b/lenskit/algorithms/tf/biasedmf.py