Skip to content

Commit

Permalink
Merge pull request #344 from mdekstrand/tweak/drop-old-python
Browse files Browse the repository at this point in the history
Drop support for Python 3.8 and 3.9
  • Loading branch information
mdekstrand committed Nov 10, 2023
2 parents 3179988 + 62bce00 commit acdc3ad
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 23 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/test-suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ jobs:
fail-fast: false
matrix:
python:
- "3.8"
- "3.9"
- "3.10"
# - "3.11"
platform:
Expand Down Expand Up @@ -83,7 +81,7 @@ jobs:
uses: lenskit/lkbuild/actions/setup-conda-env@main
id: setup
with:
python-version: '3.8'
python-version: '3.10'
extras: demo

- name: Inspect Conda environment
Expand Down Expand Up @@ -138,8 +136,6 @@ jobs:
fail-fast: false
matrix:
python:
- "3.8"
- "3.9"
- "3.10"
- "3.11"
platform:
Expand Down Expand Up @@ -181,7 +177,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v1
with:
python-version: '3.8'
python-version: '3.10'
architecture: x64

- name: Set up Python deps
Expand Down
6 changes: 5 additions & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
version: 2

build:
os: ubuntu-22.04
tools:
python: "3.11"

sphinx:
configuration: docs/conf.py

python:
version: 3.8
install:
- method: pip
path: .
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ authors = [
classifiers = [
"License :: OSI Approved :: MIT License",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Operating System :: OS Independent",
Expand Down
10 changes: 1 addition & 9 deletions tests/test_als_explicit.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,8 @@
import logging
import pickle

from numpy.lib.npyio import _save_dispatcher

# get a usable pickle disassembler
if pickle.HIGHEST_PROTOCOL >= 5:
from pickletools import dis as pickle_dis
else:
try:
from pickle5.pickletools import dis as pickle_dis
except ImportError:
pass
from pickletools import dis as pickle_dis

from lenskit.algorithms import als
from lenskit import util
Expand Down
5 changes: 0 additions & 5 deletions tests/test_batch_recommend.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@
from lenskit import batch, topn
import lenskit.crossfold as xf

try:
import pickle5
except ImportError:
pickle5 = None

MLB = namedtuple('MLB', ['ratings', 'algo'])
_log = logging.getLogger(__name__)

Expand Down

0 comments on commit acdc3ad

Please sign in to comment.