Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSR class in favor of separate library #218

Merged
merged 28 commits into from Feb 7, 2021

Conversation

mdekstrand
Copy link
Member

This makes LensKit use the external CSR library instead of carrying the CSR code around in our source tree.

@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label Feb 6, 2021
@mdekstrand mdekstrand added this to the 0.12.0 milestone Feb 6, 2021
@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #218 (eb324ec) into main (2d13052) will increase coverage by 0.18%.
The diff coverage is 95.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   92.42%   92.61%   +0.18%     
==========================================
  Files          43       41       -2     
  Lines        3987     3451     -536     
==========================================
- Hits         3685     3196     -489     
+ Misses        302      255      -47     
Impacted Files Coverage Δ
lenskit/algorithms/tf/__init__.py 75.00% <0.00%> (-6.82%) ⬇️
lenskit/algorithms/tf/bpr.py 89.43% <75.00%> (+0.07%) ⬆️
lenskit/data.py 93.33% <93.33%> (ø)
lenskit/algorithms/item_knn.py 84.02% <98.18%> (+3.03%) ⬆️
lenskit/algorithms/als.py 97.76% <100.00%> (+0.01%) ⬆️
lenskit/algorithms/basic.py 93.08% <100.00%> (ø)
lenskit/algorithms/implicit.py 82.60% <100.00%> (ø)
lenskit/algorithms/svd.py 94.64% <100.00%> (ø)
lenskit/algorithms/user_knn.py 97.58% <100.00%> (-0.17%) ⬇️
lenskit/util/test.py 87.50% <100.00%> (+0.46%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d13052...eb324ec. Read the comment docs.

@mdekstrand mdekstrand marked this pull request as ready for review February 7, 2021 01:12
@mdekstrand mdekstrand merged commit 5c36ce2 into lenskit:main Feb 7, 2021
@mdekstrand mdekstrand deleted the feature/csr branch February 7, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal infrastructure (parallelism, math, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant