Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point source refactoring #338

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Point source refactoring #338

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
570ca17
changed 'point_amp' to 'image_amp' for point source amplitudes define…
sibirrer Jul 24, 2022
0350dba
minor documentation improvements
sibirrer Jul 24, 2022
c5befdd
updated mailing list to mailing list and Slack channel
sibirrer Aug 13, 2022
a53fe49
added citation guidelines
sibirrer Aug 13, 2022
5ec3998
change JOSS link
sibirrer Aug 13, 2022
41db665
Merge branch 'main' into point_source_refactoring
sibirrer Aug 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lenstronomy/PointSource/Types/base_ps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ def __init__(self, lens_model=None, fixed_magnification=False, additional_image=

:param lens_model: instance of the LensModel() class
:param fixed_magnification: bool. If True, magnification
ratio of point sources is fixed to the one given by the lens model
ratio of point sources is fixed to the one given by the lens model.
If True, amplitude parameters are passed as 'source_amp'.
If False, amplitudes are passed as in the image plane as 'image_amp'.
:param additional_image: bool. If True, search for additional images of the same source is conducted.
"""
self._lens_model = lens_model
Expand Down
2 changes: 1 addition & 1 deletion lenstronomy/PointSource/Types/lensed_position.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class LensedPositions(PSBase):
"""
class of a a lensed point source parameterized as the (multiple) observed image positions
Name within the PointSource module: 'LENSED_POSITION'
parameters: ra_image, dec_image, point_amp
parameters: ra_image, dec_image, source_amp/source_amp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to image_amp/source_amp

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to explicitly write "source_amp is the amplitude of the point source in the source plane. image_amp are the amplitudes of the point source images in the image plane. When fixed_magnification=True, use source_amp. Otherwise, use image_amp" (in source_position as well)

If fixed_magnification=True, than 'source_amp' is a parameter instead of 'image_amp'

"""
Expand Down