Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/crop channel picture2 #247

Closed
wants to merge 32 commits into from
Closed

Feat/crop channel picture2 #247

wants to merge 32 commits into from

Conversation

keivinonline
Copy link

Description

Closes #56

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor changes in old functionality

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

keivinonline and others added 25 commits October 16, 2022 02:11
@keivinonline
WIP: cropping works
93006bc
@keivinonline
fixed cropping modal
66050f1
@keivinonline
added typing and refactored
2bc72d1
@keivinonline
fixed rotation
6d9828c
@keivinonline
removed unused code
c63e731
@keivinonline
added helper function
52f6941
@keivinonline
fixed logic flow
153ec44
@keivinonline
formatted and linted
c70a8bf
@keivinonline
refactored CropModal
59b70b2
@keivinonline
fixed typing
881601a
@keivinonline
added useEffect to upload to IPFS
1dc3b92
@keivinonline
updated file type information
3684d54
@sasicodes
Merge branch 'testnet' into feat/crop-channel-picture
6871219
@keivinonline
fixed cropping
c5cc6a2
@keivinonline
removed debug
1c41fb6
@keivinonline
WIP: crop area is missing
d587528
@keivinonline
removed react-easy-crop
a120d0d
@keivinonline
shifted to CropModal
7227c26
@keivinonline
remove unused code
7d85906
@keivinonline
removed materialUI
baff541
@keivinonline
WIP: cropping
911ee2b
@keivinonline
crop is working finally
f43c01d
@keivinonline
removed unused code
fdbe47f
@keivinonline
set fixed width and height for crop preview
dd726b1
@keivinonline
Merge branch 'testnet' into feat/crop-channel-picture2
2c7c9f7
@vercel
Copy link

vercel bot commented Oct 24, 2022

@0xkeivin is attempting to deploy a commit to the Lenstube Team on Vercel.

A member of the Team first needs to authorize it.

@keivinonline
Copy link
Author

Preview of cropping:

Screen.Recording.2022-10-24.at.11.24.24.PM.mov

@keivinonline
changes:
54c9fd7 
- set crop to rectangle
- set max height 80vh
- centered crop preview
@keivinonline
Copy link
Author

Latest crop sample:

react-image-crop_sample2.mov

@keivinonline keivinonline changed the base branch from main to testnet October 24, 2022 17:09
@sasicodes
Copy link
Member

sasicodes commented Oct 24, 2022 •
edited

@0xkeivin looks good, we can remove the title "Crop Preview" and give some top/bottom margin to the cropping image.

@vercel
Copy link

vercel bot commented Oct 24, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenstube ❌ Failed (Inspect) Oct 27, 2022 at 6:13AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 24, 2022 17:31 Inactive
@sasicodes sasicodes mentioned this pull request Oct 24, 2022
Closed
8 tasks
@sasicodes sasicodes changed the base branch from testnet to main October 25, 2022 10:00
@vercel vercel bot temporarily deployed to Preview October 25, 2022 10:11 Inactive
@vercel vercel bot temporarily deployed to Preview October 27, 2022 06:13 Inactive
@sasicodes
Copy link
Member

We can continue on this later based on priority. Thanks 🙇🏻

@sasicodes sasicodes closed this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasicodes sasicodes Awaiting requested review from sasicodes sasicodes is a code owner

Assignees

@keivinonline keivinonline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crop Channel Picture
2 participants
@keivinonline @sasicodes