Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed 'picture' text from image alt #406

Merged
merged 11 commits into from Dec 5, 2022
Merged

Conversation

zt4ff
Copy link
Contributor

@zt4ff zt4ff commented Nov 24, 2022

Description

Closes #365

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Nov 24, 2022

@zt4ff is attempting to deploy a commit to the Lenstube Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 11:23AM (UTC)
assets ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 11:23AM (UTC)
embed ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 11:23AM (UTC)
web ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 11:23AM (UTC)

@vercel vercel bot temporarily deployed to Preview – web November 24, 2022 22:02 Inactive
@vercel vercel bot temporarily deployed to Preview – embed November 24, 2022 22:04 Inactive
@vercel vercel bot temporarily deployed to Preview – assets November 24, 2022 22:04 Inactive
@vercel vercel bot temporarily deployed to Preview – assets November 25, 2022 08:19 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 25, 2022 08:21 Inactive
@vercel vercel bot temporarily deployed to Preview – embed November 25, 2022 08:22 Inactive
@vercel vercel bot temporarily deployed to Preview – assets November 26, 2022 07:24 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 26, 2022 07:26 Inactive
@vercel vercel bot temporarily deployed to Preview – embed November 26, 2022 07:26 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 2, 2022 09:05 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 2, 2022 09:07 Inactive
@sasicodes
Copy link
Member

@zt4ff any update on this ser?

@zt4ff
Copy link
Contributor Author

zt4ff commented Dec 5, 2022

@sasicodes, I updated it based on the comment to use the channel handle.

So I used the .handle based on where the image src is coming from

@sasicodes
Copy link
Member

sasicodes commented Dec 5, 2022

@zt4ff you can just do alt={channel.handle} right? why template literal (alt={${channel.handle}}`) ?

@zt4ff
Copy link
Contributor Author

zt4ff commented Dec 5, 2022

@sasicodes
For the most part, the .handle have the any type.

Typescript did not complain about i though

@sasicodes
Copy link
Member

@sasicodes For the most part, the .handle have the any type.

Typescript did not complain about i though

handle is a mandatory field in the profile. it should work I think 🤔

do you see ts warnings?

@zt4ff
Copy link
Contributor Author

zt4ff commented Dec 5, 2022

@sasicodes For the most part, the .handle have the any type.
Typescript did not complain about i though

handle is a mandatory field in the profile. it should work I think thinking

do you see ts warnings?

No, I did not see any warning
Can I make the changes real quick?

@sasicodes
Copy link
Member

@sasicodes For the most part, the .handle have the any type.
Typescript did not complain about i though

handle is a mandatory field in the profile. it should work I think thinking
do you see ts warnings?

No, I did not see any warning Can I make the changes real quick?

yes, please!

@zt4ff
Copy link
Contributor Author

zt4ff commented Dec 5, 2022

@sasicodes For the most part, the .handle have the any type.
Typescript did not complain about i though

handle is a mandatory field in the profile. it should work I think thinking
do you see ts warnings?

No, I did not see any warning Can I make the changes real quick?

yes, please!

@sasicodes I made a push

Copy link
Member

@sasicodes sasicodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview – web December 5, 2022 10:40 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 5, 2022 11:19 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 5, 2022 11:23 Inactive
@sasicodes sasicodes merged commit 6659272 into tapexyz:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(JS-0750) Prefer not to use words image, photo in image alt content
2 participants