Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added button role to divs with click handlers #397

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

zt4ff
Copy link
Contributor

@zt4ff zt4ff commented Nov 23, 2022

Description

Closes #371

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Nov 23, 2022

@zt4ff is attempting to deploy a commit to the Lenstube Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 7:29PM (UTC)
assets ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 7:29PM (UTC)
embed ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 7:29PM (UTC)
web ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 7:29PM (UTC)

@vercel vercel bot temporarily deployed to Preview – assets November 23, 2022 09:50 Inactive
@vercel vercel bot temporarily deployed to Preview – api November 23, 2022 09:56 Inactive
@vercel vercel bot temporarily deployed to Preview – embed November 23, 2022 09:56 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 23, 2022 09:57 Inactive
@sasicodes
Copy link
Member

@zt4ff can you delete the yarn.lock changes?

@vercel vercel bot temporarily deployed to Preview – assets November 23, 2022 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview – assets November 23, 2022 17:10 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 23, 2022 17:28 Inactive
@zt4ff
Copy link
Contributor Author

zt4ff commented Nov 23, 2022

@sasicodes
I think you removed the yarn.lock changes from this file changed in this PR
I can't find it here: https://github.com/lenstube-xyz/lenstube/pull/397/files

@vercel vercel bot temporarily deployed to Preview – assets November 23, 2022 19:15 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 23, 2022 19:16 Inactive
@vercel vercel bot temporarily deployed to Preview – embed November 23, 2022 19:17 Inactive
@vercel vercel bot temporarily deployed to Preview – api November 23, 2022 19:29 Inactive
@sasicodes
Copy link
Member

LGTM

@sasicodes sasicodes merged commit cdd732f into tapexyz:main Nov 23, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Nov 23, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Lenstube Contributor:

GitPOAP: 2022 Lenstube Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@sasicodes
Copy link
Member

@zt4ff please collect you gitpoap

@zt4ff
Copy link
Contributor Author

zt4ff commented Nov 24, 2022

@zt4ff please collect you gitpoap

Thanks. I already collected it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants