Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added a title to nftcard iframe #399

Merged
merged 7 commits into from
Dec 7, 2022
Merged

Conversation

zt4ff
Copy link
Contributor

@zt4ff zt4ff commented Nov 23, 2022

Description

Closes #366

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Nov 23, 2022

@zt4ff is attempting to deploy a commit to the Lenstube Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 6:46AM (UTC)
assets ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 6:46AM (UTC)
embed ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 6:46AM (UTC)
web ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 6:46AM (UTC)

@vercel vercel bot temporarily deployed to Preview – assets November 23, 2022 16:55 Inactive
@vercel vercel bot temporarily deployed to Preview – assets November 23, 2022 19:35 Inactive
@vercel vercel bot temporarily deployed to Preview – api November 23, 2022 19:36 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 23, 2022 19:37 Inactive
@vercel vercel bot temporarily deployed to Preview – embed November 23, 2022 19:47 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 25, 2022 07:31 Inactive
@vercel vercel bot temporarily deployed to Preview – assets November 25, 2022 07:31 Inactive
@vercel vercel bot temporarily deployed to Preview – embed November 25, 2022 07:32 Inactive
@vercel vercel bot temporarily deployed to Preview – assets November 26, 2022 07:27 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 26, 2022 07:28 Inactive
@vercel vercel bot temporarily deployed to Preview – embed November 26, 2022 07:29 Inactive
@sasicodes
Copy link
Member

@zt4ff can you address the comments please 🙇🏻 ?

@vercel vercel bot temporarily deployed to Preview – embed December 5, 2022 09:29 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 5, 2022 10:14 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 6, 2022 23:08 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 6, 2022 23:09 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 7, 2022 06:41 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 7, 2022 06:44 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 7, 2022 06:46 Inactive
@sasicodes sasicodes merged commit 6bef127 into tapexyz:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(JS-0749) Prefer to have a unique title in <iframe>
2 participants