Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimistic post and quick delete from cache #454

Merged
merged 13 commits into from
Dec 10, 2022
Merged

feat: optimistic post and quick delete from cache #454

merged 13 commits into from
Dec 10, 2022

Conversation

sasicodes
Copy link
Member

@sasicodes sasicodes commented Dec 10, 2022

Description

Closes #453
Closes #275

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor changes in old functionality

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Dec 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
embed ✅ Ready (Inspect) Visit Preview Dec 10, 2022 at 2:55PM (UTC)
web ✅ Ready (Inspect) Visit Preview Dec 10, 2022 at 2:55PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
api ⬜️ Ignored (Inspect) Dec 10, 2022 at 2:55PM (UTC)

@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 11:19 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 10, 2022 11:19 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 11:21 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 10, 2022 11:22 Inactive
if (selectedChannelId) {
replace(query?.next ? (query?.next as string) : '/')
if (selectedChannelId && query?.next) {
replace(query?.next as string)

Check warning

Code scanning / CodeQL

Client-side URL redirect

Untrusted URL redirection depends on a [user-provided value](1).
@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 11:28 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 10, 2022 11:29 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 10, 2022 12:02 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 12:02 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 10, 2022 12:14 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 12:15 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 12:28 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 10, 2022 12:28 Inactive
@sasicodes sasicodes self-assigned this Dec 10, 2022
@sasicodes sasicodes marked this pull request as ready for review December 10, 2022 14:12
@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 14:21 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 10, 2022 14:22 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 10, 2022 14:28 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 14:28 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 10, 2022 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 10, 2022 14:44 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 14:45 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 14:52 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 10, 2022 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 10, 2022 14:55 Inactive
@sasicodes sasicodes merged commit 83ad0cf into main Dec 10, 2022
@sasicodes sasicodes deleted the feat-275 branch December 10, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete video without reload (evict cache) Optimistic Post
1 participant