Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mux data integration #486

Merged
merged 17 commits into from
Dec 20, 2022
Merged

feat: mux data integration #486

merged 17 commits into from
Dec 20, 2022

Conversation

suhailkakar
Copy link
Contributor

Description

Integrated Mux to track videos

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor changes in old functionality

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Integrated Mux to track videos
@vercel
Copy link

vercel bot commented Dec 19, 2022

@suhailkakar is attempting to deploy a commit to the Lenstube Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 0:30AM (UTC)
embed ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 0:30AM (UTC)
web ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 0:30AM (UTC)

@vercel vercel bot temporarily deployed to Preview – embed December 19, 2022 14:22 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 19, 2022 14:23 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 19, 2022 14:32 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 19, 2022 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 19, 2022 15:59 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 19, 2022 16:01 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 19, 2022 16:06 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 19, 2022 16:07 Inactive
packages/web-ui/VideoPlayer/index.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – embed December 19, 2022 16:09 Inactive
@sasicodes
Copy link
Member

sasicodes commented Dec 19, 2022

@suhailkakar There is a lint issue in web-ui/VideoPlayer/index.tsx, can you run yarn lint:fix in the workspace root? 🙇🏻

Also, the typedef's missing!
image

@sasicodes sasicodes changed the title feat: integrated Mux feat: mux integration Dec 19, 2022
@sasicodes sasicodes changed the title feat: mux integration feat: mux data integration Dec 19, 2022
packages/utils/constants.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – web December 19, 2022 17:20 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 19, 2022 17:22 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 19, 2022 17:59 Inactive
@suhailkakar
Copy link
Contributor Author

@sasicodes I have fixed the lint issue, renamed the env and installed the package in the web-ui only.

lmk if it works.

Also not sure what is the issue with Checks / CI (pull_request) , Vercel – embed . Can't see the reason so I can fix them!

@vercel vercel bot temporarily deployed to Preview – web December 19, 2022 18:06 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 19, 2022 18:29 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 19, 2022 18:30 Inactive
@suhailkakar
Copy link
Contributor Author

@suhailkakar Yes! But during the build the error happens, saying Type error: Could not find a declaration file for module 'mux-embed'.

I tried with custom declaration, but same error on build in local 🤔

I see, and I was able to reproduce it. I believe the error is related to the mux-embed types of deceleration. You can add // @ts-ignore so Typescript can ignore that package. However, I don't think it is the best approach.

WDYT?

@sasicodes
Copy link
Member

@suhailkakar Yes! But during the build the error happens, saying Type error: Could not find a declaration file for module 'mux-embed'.
I tried with custom declaration, but same error on build in local 🤔

I see, and I was able to reproduce it. I believe the error is related to the mux-embed types of deceleration. You can add // @ts-ignore so Typescript can ignore that package. However, I don't think it is the best approach.

WDYT?

Thats not the recommended approach, but defining typedef is also not working 😞 Will check else we can use ts-ignore for now.

@suhailkakar are you using your personal mux key?

@vercel vercel bot temporarily deployed to Preview – api December 20, 2022 11:23 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 20, 2022 11:25 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 20, 2022 11:28 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 20, 2022 11:30 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 20, 2022 11:30 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 20, 2022 11:43 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 20, 2022 11:48 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 20, 2022 11:48 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 20, 2022 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 20, 2022 12:18 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 20, 2022 12:19 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 20, 2022 12:19 Inactive
@vercel vercel bot temporarily deployed to Preview – web December 20, 2022 12:29 Inactive
@vercel vercel bot temporarily deployed to Preview – embed December 20, 2022 12:29 Inactive
@vercel vercel bot temporarily deployed to Preview – api December 20, 2022 12:30 Inactive
Copy link
Member

@sasicodes sasicodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sasicodes sasicodes merged commit 7881d53 into tapexyz:main Dec 20, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 20, 2022

Congrats @suhailkakar , your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Lenstube Contributor:

GitPOAP: 2022 Lenstube Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants