Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace native confirm #612

Merged

Conversation

sasicodes
Copy link
Member

@sasicodes sasicodes commented Feb 13, 2023

Description

Closes #543

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor changes in old functionality

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@sasicodes sasicodes linked an issue Feb 13, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
embed ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 3:16PM (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 3:16PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
api ⬜️ Ignored (Inspect) Feb 13, 2023 at 3:16PM (UTC)

@vercel vercel bot temporarily deployed to Preview – embed February 13, 2023 15:02 Inactive
@vercel vercel bot temporarily deployed to Preview – web February 13, 2023 15:04 Inactive
@vercel vercel bot temporarily deployed to Preview – embed February 13, 2023 15:13 Inactive
@vercel vercel bot temporarily deployed to Preview – web February 13, 2023 15:16 Inactive
@vercel vercel bot temporarily deployed to Preview – embed February 13, 2023 15:16 Inactive
@sasicodes sasicodes merged commit c33730d into main Feb 13, 2023
@sasicodes sasicodes deleted the 543-js-0052-detected-the-use-of-alert-confirm-and-prompt branch February 13, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(JS-0052) Detected the use of alert, confirm and prompt
1 participant