Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use ar:// for arweave urls #630

Merged
merged 2 commits into from
Feb 18, 2023
Merged

feat: use ar:// for arweave urls #630

merged 2 commits into from
Feb 18, 2023

Conversation

sasicodes
Copy link
Member

@sasicodes sasicodes commented Feb 18, 2023 •
edited

Description

Closes #(issue-number)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor changes in old functionality

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@sasicodes sasicodes linked an issue Feb 18, 2023 that may be closed by this pull request
Add ar:// for arweave sources in metadata #552
Closed
1 task
@vercel
Copy link

vercel bot commented Feb 18, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
api ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 18, 2023 at 6:39PM (UTC)
embed ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 18, 2023 at 6:39PM (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 18, 2023 at 6:39PM (UTC)

@sasicodes sasicodes changed the title feat: use ar:// for arweave feat: use ar:// for arweave urls Feb 18, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 18, 2023
View reviewed changes
apps/web/src/components/Upload/ChooseThumbnail.tsx
@@ -191,7 +191,7 @@
>
<img
className="h-16 w-full rounded-lg object-cover md:w-32"
src={sanitizeIpfsUrl(thumbnail.url)}
src={sanitizeDStorageUrl(thumbnail.url)}

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML

[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
@vercel vercel bot temporarily deployed to Preview – api February 18, 2023 18:39 Inactive
@sasicodes sasicodes merged commit fb58fa6 into main Feb 18, 2023
@sasicodes sasicodes deleted the 552-add-ar-for-arweave-sources-in-metadata branch February 18, 2023 19:05
sasicodes added a commit that referenced this pull request Feb 18, 2023
@sasicodes
Revert "feat: use ar:// for arweave urls (#630)"
ab5cda3 
This reverts commit fb58fa6.
@sasicodes sasicodes mentioned this pull request Feb 18, 2023
Merged
@sasicodes sasicodes restored the 552-add-ar-for-arweave-sources-in-metadata branch February 18, 2023 19:34
sasicodes added a commit that referenced this pull request Feb 18, 2023
@sasicodes
Revert "feat: use ar:// for arweave urls (#630)" (#631)
f5051dd 
This reverts commit fb58fa6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ar:// for arweave sources in metadata
1 participant
@sasicodes